Rename TransmissionCompletedSize event and add received event #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only reported on the size of messages *transmitted*. Now we report on the size of messages received as well. I also give the events a different `Task` name to distinguish it from the `MessageTransmission` that is already used by `JsonRpc`.
|
CC: @MokoSan |
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 90.36% 90.23% -0.14%
==========================================
Files 50 50
Lines 3892 3900 +8
==========================================
+ Hits 3517 3519 +2
- Misses 375 381 +6
Continue to review full report at Codecov.
|
MokoSan
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only reported on the size of messages transmitted. Now we report on the size of messages received as well.
I also give the events a different
Taskname to distinguish it from theMessageTransmissionthat is already used byJsonRpc.