Fixed proxy generation for methods with many parameters #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not use the short form jump instruction when the instructions between the jump source and target may exceed 127... (IL instructions? bytes?). Anyway, as a rule then, I've switched to long form whenever the jump crosses an IL generating loop, such that we can't be confident that the number of instructions will be small.
Codecov Report
@@ Coverage Diff @@
## release/vs/16.8-preview.1 #506 +/- ##
============================================================
Coverage ? 89.51%
============================================================
Files ? 50
Lines ? 4033
Branches ? 0
============================================================
Hits ? 3610
Misses ? 423
Partials ? 0 Continue to review full report at Codecov.
|
javierdlg
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not use the short form jump instruction when the instructions between the jump source and target may exceed 127... (IL instructions? bytes?). Anyway, as a rule then, I've switched to long form whenever the jump crosses an IL generating loop, such that we can't be confident that the number of instructions will be small.
This regressed in 9cf9f7e