Only raise events from RPC targets once #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, when events were declared (as abstract or virtual) on a base class and overridden in the target object, we attached a handler to the event once for each time it was declared in the hierarchy, leading to multiple invocations on the client. Fixes microsoft#481
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
==========================================
- Coverage 89.21% 89.12% -0.09%
==========================================
Files 51 51
Lines 4071 4075 +4
==========================================
Hits 3632 3632
- Misses 439 443 +4
Continue to review full report at Codecov.
|
milopezc
approved these changes
Aug 12, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, when events were declared (as abstract or virtual) on a base class and overridden in the target object, we attached a handler to the event once for each time it was declared in the hierarchy, leading to multiple invocations on the client.
Fixes #481