Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch default to to retain order of incoming RPC invocations #525

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 13, 2020

Closes #521

@AArnott AArnott added this to the v2.6 milestone Aug 13, 2020
@AArnott AArnott requested a review from milopezc August 13, 2020 15:56
@AArnott AArnott self-assigned this Aug 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #525 into master will decrease coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   89.28%   89.18%   -0.11%     
==========================================
  Files          51       51              
  Lines        4059     4076      +17     
==========================================
+ Hits         3624     3635      +11     
- Misses        435      441       +6     
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 92.50% <100.00%> (+<0.01%) ⬆️
src/StreamJsonRpc/WebSocketMessageHandler.cs 87.03% <0.00%> (-10.34%) ⬇️
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 94.25% <0.00%> (-1.15%) ⬇️
src/StreamJsonRpc/MessageHandlerBase.cs 100.00% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c112357...1771361. Read the comment docs.

milopezc
milopezc approved these changes Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonRpc should preserve order of invocations on RPC server by default
3 participants