Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for marshaling IObserver<T> over RPC #536

Merged
merged 5 commits into from
Aug 26, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Aug 25, 2020

Also:

  • Fix proxies to accept multiple Dispose calls
  • Centralize list of implicitly marshaled types across formatters

Closes #346

@AArnott AArnott added this to the v2.6 milestone Aug 25, 2020
@AArnott AArnott self-assigned this Aug 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #536 into master will increase coverage by 0.24%.
The diff coverage is 97.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   89.47%   89.72%   +0.24%     
==========================================
  Files          53       53              
  Lines        4258     4408     +150     
==========================================
+ Hits         3810     3955     +145     
- Misses        448      453       +5     
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonMessageFormatter.cs 91.17% <92.85%> (-0.11%) ⬇️
src/StreamJsonRpc/MessagePackFormatter.cs 91.69% <93.54%> (+0.02%) ⬆️
src/StreamJsonRpc/JsonRpc.cs 92.48% <100.00%> (-0.31%) ⬇️
src/StreamJsonRpc/JsonRpcProxyOptions.cs 90.00% <100.00%> (+1.11%) ⬆️
src/StreamJsonRpc/ProxyGeneration.cs 99.78% <100.00%> (+0.03%) ⬆️
...tion/MessageFormatterRpcMarshaledContextTracker.cs 96.19% <100.00%> (+3.76%) ⬆️
src/StreamJsonRpc/MessageHandlerBase.cs 100.00% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ca9f2...64c9625. Read the comment docs.

doc/observer.md Outdated Show resolved Hide resolved
@AArnott AArnott merged commit 7bbbcf7 into microsoft:master Aug 26, 2020
@AArnott AArnott deleted the iobserver branch August 26, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for passing IObserver<T> objects over RPC
4 participants