Tighten up exceptions thrown by formatters #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything checks out, but this resolves a concern brought up in microsoft#246
- `ConnectionLostException` is thrown when the connection drops (due to local Dispose call) on a pending outbound call. - `OperationCanceledException` is thrown in the prior scenario but when the outbound call's `CancellationToken` is signaled. - An RPC server in an callback will itself experience `OperationCanceledException` instead of `ConnectionLostException` if the client disconnects.
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.03%
==========================================
Files 53 53
Lines 4408 4418 +10
==========================================
+ Hits 3957 3965 +8
- Misses 451 453 +2
Continue to review full report at Codecov.
|
milopezc
approved these changes
Sep 2, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap any/all exceptions thrown by formatters in the exception type native to their serializer.
This PR builds on #538, so until that completes, the diff on this PR will look larger than its one unique commit.