Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IProgress<T> when T is a MessagePack [Union] type #540

Merged
2 commits merged into from
Sep 3, 2020
Merged

Fix IProgress<T> when T is a MessagePack [Union] type #540

2 commits merged into from
Sep 3, 2020

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 2, 2020

Fixes #537

@AArnott AArnott added this to the v2.6 milestone Sep 2, 2020
@AArnott AArnott self-assigned this Sep 2, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2020

Codecov Report

Merging #540 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   89.76%   89.70%   -0.07%     
==========================================
  Files          53       53              
  Lines        4408     4410       +2     
==========================================
- Hits         3957     3956       -1     
- Misses        451      454       +3     
Impacted Files Coverage Δ
...nRpc/Reflection/MessageFormatterProgressTracker.cs 94.80% <100.00%> (+0.13%) ⬆️
src/StreamJsonRpc/JsonRpc.cs 92.48% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2579f9...d9171bf. Read the comment docs.

@ghost ghost merged commit fde90ef into master Sep 3, 2020
@ghost ghost deleted the fix537 branch September 3, 2020 00:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IProgress<T> support fails when using MessagePack where T is a [Union] type
3 participants