Add ICancellationStrategy extensibility point #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
==========================================
+ Coverage 89.72% 89.86% +0.13%
==========================================
Files 53 54 +1
Lines 4420 4438 +18
==========================================
+ Hits 3966 3988 +22
+ Misses 454 450 -4
Continue to review full report at Codecov.
|
heejaechang
reviewed
Sep 3, 2020
This allows specific JsonRpc instances to be configured to implement `CancellationToken` support in a totally different way. They are *not* given the freedom to mutate the the request object itself, but they may trigger and respond to any other JSON-RPC message or do something entirely out of band (e.g. creating a file and/or testing for existing of the file). As part of this change, we had to move `$/cancelRequest` handling out of its very special place in `JsonRpc.HandleRpcAsync` into a standard method handler. But that would have changed the method handler to be invoked on the user-configurable `SynchronizationContext` (which is now by default order-preserving). But this special method *shouldn't* be subject to that order-preserving `SynchronizationContext` because in fact we want these cancellation requests handled as soon as they come in so they can cancel an ongoing RPC server method that has not yet yielded. In order to support this, I modified how we record `TargetMethod` to include an optional override `SynchronizationContext`.
milopezc
approved these changes
Sep 3, 2020
This is important to support strategy implementations that create a file in `CancelOutboundRequest` and must delete it when the cancellation request has completed.
|
@AArnott thank you! when will this be inserted to VS? |
|
@huguesv for FYI |
|
@heejaechang StreamJsonRpc insertions happen nightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specific JsonRpc instances to be configured to implement
CancellationTokensupport in a totally different way. They are not given the freedom to mutate the the request object itself, but they may trigger and respond to any other JSON-RPC message or do something entirely out of band (e.g. creating a file and/or testing for existing of the file).As part of this change, we had to move
$/cancelRequesthandling out of its very special place inJsonRpc.HandleRpcAsyncinto a standard method handler. But that would have changed the method handler to be invoked on the user-configurableSynchronizationContext(which is now by default order-preserving). But this special method shouldn't be subject to that order-preservingSynchronizationContextbecause in fact we want these cancellation requests handled as soon as they come in so they can cancel an ongoing RPC server method that has not yet yielded. In order to support this, I modified how we recordTargetMethodto include an optional overrideSynchronizationContext.Closes #436