Promote error info into RemoteRpcException
#554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierdlg
approved these changes
Sep 18, 2020
Some of this error info was unique to `RemoteInvocationException` but some was replicated across `RemoteMethodNotFoundException` as well. In fact, most RPC error exceptions should include an error code, so promoting these to the base class makes sense. But not *all* `RemoteRpcException` derived types come from a JSON-RPC error, so we must allow for not having an error code. We also need to be creative to avoid any backward breaking API changes. So instead of *moving* the properties to the base class, I add them to the base class and 'redefine' them in the derived types to simply forward the value from the base class.
AArnott
force-pushed
the
exceptionApiWork
branch
from
12f1ea5 to
81ee686
Compare
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 89.92% 89.83% -0.10%
==========================================
Files 54 54
Lines 4438 4445 +7
==========================================
+ Hits 3991 3993 +2
- Misses 447 452 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of this error info was unique to
RemoteInvocationExceptionbut some was replicated acrossRemoteMethodNotFoundExceptionas well. In fact, most RPC error exceptions should include an error code, so promoting these to the base class makes sense.But not all
RemoteRpcExceptionderived types come from a JSON-RPC error, so we must allow for not having an error code.We also need to be creative to avoid any backward breaking API changes. So instead of moving the properties to the base class, I add them to the base class and 'redefine' them in the derived types to simply forward the value from the base class.