Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Newtonsoft.Json assembly load in non JSON scenario #556

Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 19, 2020

No description provided.

@AArnott AArnott added this to the v2.6 milestone Sep 19, 2020
@AArnott AArnott self-assigned this Sep 19, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2020

Codecov Report

Merging #556 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
- Coverage   89.82%   89.82%   -0.01%     
==========================================
  Files          55       55              
  Lines        4463     4461       -2     
==========================================
- Hits         4009     4007       -2     
  Misses        454      454              
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 92.79% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78db3ac...73a3e54. Read the comment docs.

@AArnott AArnott force-pushed the dev/andarno/fixNewtonsoftAssemblyLoad branch from e85134a to 73a3e54 Compare September 19, 2020 14:49
@AArnott AArnott merged commit 09a1975 into microsoft:master Sep 19, 2020
@AArnott AArnott deleted the dev/andarno/fixNewtonsoftAssemblyLoad branch September 19, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants