Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Nerdbank.Streams from 2.5.76 to 2.6.77 in /src #559

Merged
merged 2 commits into from
Sep 21, 2020

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 21, 2020

Bumps Nerdbank.Streams from 2.5.76 to 2.6.77.

Release notes

Sourced from Nerdbank.Streams's releases.

v2.6.77

Changes:

Fixes:

  • #245: Fix uncaught promise rejection when cancelling a channel offer
  • #244: Remove .js.map file or add .ts file
  • #227: Fix compiler error when users of Substream do not reference our ref assemblies
  • #246: Fix js->ts maps

Others:

This list of changes was auto generated.

v2.6.37-alpha

Changes:

Enhancements:

  • #207: Embrace new System.IO.Pipelines functionality
  • #194: Add support for seeded channels to MultiplexingStream
  • #193: Switch channel IDs from long to ulong
  • #191: Make MultiplexingStream.Options freezable
  • #190: Add synchronous MultiplexingStream.Create method for v3
  • #187: Avoid round-trip handshake for multiplexing stream
  • #199: Add MonitoringStream.IsDisposed property

This list of changes was auto generated.

Commits
  • 10efc9a Set version to '2.6'
  • 1a0d9bd Merge remote-tracking branch 'origin/v2.5' into master
  • 6289cb4 Merge pull request #246 from AArnott/fix244
  • 465cad2 Merge pull request #245 from AArnott/fixChannelOfferCancellation
  • c273f3b Fix js->ts maps
  • 7b50716 Avoid uncaught promise rejection when canceling a channel offer
  • 2255046 Add test for canceling channel offers
  • 2155d57 Syntax touch-ups
  • 4e1dfcb Bump @types/node from 14.6.4 to 14.10.1 in /src/nerdbank-streams (#243)
  • 70cb561 Bump @types/node from 14.6.2 to 14.6.4 in /src/nerdbank-streams (#240)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @AArnott.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 21, 2020
We had to avoid some Obsolete APIs.
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #559 into master will decrease coverage by 0.00%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.01%     
==========================================
  Files          55       55              
  Lines        4461     4467       +6     
==========================================
+ Hits         4009     4014       +5     
- Misses        452      453       +1     
Impacted Files Coverage Δ
...pc/Reflection/MessageFormatterDuplexPipeTracker.cs 89.24% <70.00%> (-5.01%) ⬇️
src/StreamJsonRpc/JsonMessageFormatter.cs 91.27% <100.00%> (ø)
src/StreamJsonRpc/MessagePackFormatter.cs 91.72% <100.00%> (ø)
src/StreamJsonRpc/PipeMessageHandler.cs 90.78% <100.00%> (ø)
src/StreamJsonRpc/JsonRpc.cs 93.44% <0.00%> (+0.32%) ⬆️
src/StreamJsonRpc/MessageHandlerBase.cs 100.00% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a1975...4217ceb. Read the comment docs.

@AArnott AArnott force-pushed the dependabot/nuget/src/Nerdbank.Streams-2.6.77 branch from 89f4841 to 4217ceb Compare September 21, 2020 15:28
@AArnott
Copy link
Member

AArnott commented Sep 21, 2020

@dependabot merge

@AArnott AArnott added this to the v2.6 milestone Sep 21, 2020
@dependabot dependabot bot merged commit 545c9d0 into master Sep 21, 2020
@dependabot dependabot bot deleted the dependabot/nuget/src/Nerdbank.Streams-2.6.77 branch September 21, 2020 15:36
AArnott added a commit that referenced this pull request Sep 21, 2020
This fixes a stability regression introduced in #559 which was detected by the `MessageHeaderTests`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants