-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow marshalable objects to implement additional optional interfaces #843
Allow marshalable objects to implement additional optional interfaces #843
Conversation
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is remarkable how well this fits in and how quickly you wrote it up. I have lots of comments, but I'm very enthusiastic about what you're proposing here.
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubtypeAttribute.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #843 +/- ##
==========================================
+ Coverage 91.67% 91.69% +0.02%
==========================================
Files 134 135 +1
Lines 13343 13689 +346
==========================================
+ Hits 12232 12552 +320
- Misses 1111 1137 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubTypeAttribute.cs
Outdated
Show resolved
Hide resolved
…y implemented methods from non-Rpc interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff. I still need to review the ProxyGeneration and tests, but thought I'd offer my feedback so far.
Note I did push a commit to your branch with a few small changes I just made instead of commenting asking you to make them.
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubTypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/RpcMarshalableKnownSubTypeAttribute.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
src/StreamJsonRpc/Reflection/MessageFormatterRpcMarshaledContextTracker.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished reviewing.
No description provided.