Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VSTHRD004 mis-fire on NoThrowAwaitable() #1243

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Oct 23, 2023

Fixes #1232

}
}
";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra newline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty line between the test snippet and the assertion is actually customary in this repo.

@AArnott AArnott merged commit 753885e into microsoft:main Oct 24, 2023
6 checks passed
@AArnott AArnott deleted the fix1232 branch October 24, 2023 19:09
@AArnott AArnott added this to the v17.9 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSTHRD004 fires for SwitchToMainThreadAsync().NoThrowAwaitable()
2 participants