Fix hang in AsyncLazy<T>.DisposeValue() when T : IAsyncDisposable
#1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdrobison
reviewed
Jan 5, 2024
jdrobison
reviewed
Jan 5, 2024
jdrobison
reviewed
Jan 5, 2024
`AsyncLazy<T>` had been clearing the `JoinableTaskFactory` field as soon as the value factory had completed. But with the introduction of `DisposeValue()`, we have a subsequent need of the JTF object to avoid deadlocks.
AArnott
force-pushed
the
fixAsyncLazyDispose
branch
from
5e65336
to
5544227
Compare
AArnott
force-pushed
the
fixAsyncLazyDispose
branch
from
eacdeb4
to
d36f8f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncLazy<T>had been clearing theJoinableTaskFactoryfield as soon as the value factory had completed. But with the introduction ofDisposeValue(), we have a subsequent need of the JTF object to avoid deadlocks.