Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw ObjectDisposedException consistently from AsyncSemaphore.EnterAsync #493

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Throw ObjectDisposedException consistently from AsyncSemaphore.EnterAsync #493

merged 3 commits into from
Jun 26, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jun 22, 2019

Builds on and slightly changes #105

@AArnott AArnott added this to the v16.3 milestone Jun 22, 2019
@AArnott AArnott requested review from sharwell, ikeras and lifengl June 22, 2019 15:50
@AArnott AArnott self-assigned this Jun 22, 2019
@AArnott AArnott mentioned this pull request Jun 22, 2019
Closed
@AArnott AArnott changed the title Semaphore dispose Throw ObjectDisposedException consistently from AsyncSemaphore.EnterAsync Jun 22, 2019
lifengl
lifengl approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@lifengl lifengl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@AArnott AArnott merged commit d659a47 into microsoft:master Jun 26, 2019
@AArnott AArnott deleted the semaphore-dispose branch June 26, 2019 18:43
@AArnott AArnott mentioned this pull request Jun 26, 2019
Closed
@AArnott AArnott mentioned this pull request Oct 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifengl lifengl lifengl approved these changes

@sharwell sharwell Awaiting requested review from sharwell

@ikeras ikeras Awaiting requested review from ikeras

Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
v16.3
Development

Successfully merging this pull request may close these issues.
3 participants
@AArnott @lifengl @sharwell