fix: environment variable syntax

microsoft · Dec 2, 2024 · be36758 · be36758
1 parent a191156
commit be36758
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 26 deletions.
diff --git a/.github/policies/scheduler.yml b/.github/policies/scheduler.yml
@@ -12,19 +12,19 @@ configuration:
       frequencies:
       - weekday:
           day: Monday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Tuesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Wednesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Thursday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Friday
-          time: 0:0
+          time: 23:00
       filters:
       - isIssue
       - isOpen
@@ -48,19 +48,19 @@ configuration:
       frequencies:
       - weekday:
           day: Monday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Tuesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Wednesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Thursday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Friday
-          time: 0:0
+          time: 23:00
       filters:
       - isOpen
       - isIssue
@@ -83,19 +83,19 @@ configuration:
       frequencies:
       - weekday:
           day: Monday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Tuesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Wednesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Thursday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Friday
-          time: 0:0
+          time: 23:00
       filters:
       - isIssue
       - isOpen
@@ -117,19 +117,19 @@ configuration:
       frequencies:
       - weekday:
           day: Monday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Tuesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Wednesday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Thursday
-          time: 0:0
+          time: 23:00
       - weekday:
           day: Friday
-          time: 0:0
+          time: 23:00
       filters:
       - isIssue
       - isOpen
@@ -150,7 +150,7 @@ configuration:
     - description: "[Close Issue Management] For issue with close-wait label"
       frequencies:
       - daily:
-          time: 1:0
+          time: 0:0
       filters:
       - isOpen
       - isIssue

diff --git a/.github/scripts/notify-issues.js b/.github/scripts/notify-issues.js
@@ -60,7 +60,9 @@ async function main() {
     console.log(`Sending email to ${email} for issue ${JSON.stringify(issues)}`);
     const body = `
 <p>Hi, here are GitHub issues that needs your attention:</p>
-${issues.map((issue) =>`<p><a href="${issue.url}">#${issue.number}</a>: ${issue.title} (${issue.url})</p>`)}
+${issues.map((issue) =>`<p><a href="${issue.url}">#${issue.number}</a>: ${issue.title} (${issue.url})</p>
+<hr />
+<p>* Remove the "needs attention" or close the issue in order not to receive this notification.</p>`)}
 `;
     await sendEmail(
       email,

diff --git a/.github/workflows/scheduleNotification.yml b/.github/workflows/scheduleNotification.yml
@@ -15,8 +15,9 @@ jobs:
       - name: Check issues that needs attention
         run: node .github/scripts/notify-issues.js
         env:
-          REPO_MAINTAINERS: ${{ env.REPO_MAINTAINERS }}
-          WORKFLOW_MAINTAINER_EMAIL: ${{ env.SCHEDULED_NOTIFICATION_MAINTAINER_EMAIL }}
-          MAIL_CLIENT_ID: ${{ secrets.EMAIL_CLIENT_ID }}
+          REPO_MAINTAINERS: ${{ vars.REPO_MAINTAINERS }}
+          WORKFLOW_MAINTAINER_EMAIL: ${{ vars.SCHEDULED_NOTIFICATION_MAINTAINER_EMAIL }}
+          MAIL_TENANT_ID: ${{ vars.EMAIL_TENANT_ID }}
+          MAIL_CLIENT_ID: ${{ vars.EMAIL_CLIENT_ID }}
           MAIL_CLIENT_SECRET: ${{ secrets.EMAIL_CLIENT_SECRET }}
-          MAIL_TENANT_ID: ${{ secrets.EMAIL_TENANT_ID }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}