Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I would expect this to use symbol highlight not identifier highlight #6

Open
sbatten opened this issue Sep 28, 2021 · 2 comments
Open

I would expect this to use symbol highlight not identifier highlight #6

sbatten opened this issue Sep 28, 2021 · 2 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality

Comments

@sbatten
Copy link
Member

sbatten commented Sep 28, 2021

Testing #2389

https://github.dev/dotnet/samples/blob/23c9784d57fc92436aa40043bf0a4b764308a923/csharp/NullableIntroduction/NullableIntroduction/SurveyQuestion.cs#L10-L17

image
@jrieken
Copy link
Member

jrieken commented Sep 29, 2021

That's surprisingly hard because it can be used with or without this and when having arguments with the same name as properties its hard to tell them apart

@jrieken jrieken added the feature-request Request for new features or functionality label Oct 4, 2021
jrieken added a commit that referenced this issue Nov 25, 2021
@jrieken
add skipped and partial test for #6
ce96a97
@jrieken
Copy link
Member

jrieken commented Nov 25, 2021

That specific case should now be working but the this.X isn't working yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrieken @sbatten