Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates for dynamic concurrency #3248

Closed
cachai2 opened this issue Jul 16, 2022 · 2 comments · Fixed by #3365
Closed

Update templates for dynamic concurrency #3248

cachai2 opened this issue Jul 16, 2022 · 2 comments · Fixed by #3365
Assignees
Labels
Milestone

Comments

@cachai2
Copy link

cachai2 commented Jul 16, 2022

Dynamic concurrency is a performance feature that went GA for functions end of May.

We want to enable the feature by default for new apps, and it requires updating host.json settings for the app.

@nturinski
Copy link
Member

Hi @cachai2

I created a Function App through the Portal and looking at the host.json, I'm not seeing the setting that you're referring to.

image

According to this document, the default is to have dynamic concurrency disabled.

By default, dynamic concurrency is disabled. With dynamic concurrency enabled, concurrency starts at 1 for each function, and is adjusted up to an optimal value, which is determined by the host.

Furthermore, it only seems like dynamic concurrency is supported for Azure Blob, Azure Queue, and Service Bus triggers so I'm not sure that it is something that we should turn on by default for all users.

@cachai2
Copy link
Author

cachai2 commented Aug 15, 2022

Hi @nturinski,

Currently, the default is to have dynamic concurrency disabled for Function apps on create. However, the Functions team is trying to get more usage of the feature as it will help simplify concurrency settings for customers in order to get performance improvements.

The portal creates an empty Function app by default. This experience can/should be mimicked in VS Code. However, when creating a non-empty app with Azure Blob, Azure Queue, and Service Bus Triggers, we want the template generated to default the settings for dynamic concurrency in host.json.

@motm32 motm32 added this to the 1.9.0 milestone Sep 23, 2022
@motm32 motm32 self-assigned this Sep 28, 2022
@microsoft microsoft locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants