Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency to host schema #2516

Merged

Conversation

motm32
Copy link
Contributor

@motm32 motm32 commented Oct 7, 2022

This PR adds a concurrency property to the host schema and also adds tests.
This is needed in order to enable dynamic concurrency.

@GerryFerdinandus
Copy link
Contributor

@motm32
Can you add "additionalProperties": false

According to the documentation
Dynamic concurrency is disabled by default.
But you set the default to 'true'

The default for snapshotPersistenceEnabled is correct.
When SnapshotPersistenceEnabled is true, which is the default,

@motm32
Copy link
Contributor Author

motm32 commented Oct 11, 2022

@motm32 Can you add "additionalProperties": false

Will do!

According to the documentation Dynamic concurrency is disabled by default. But you set the default to 'true'

Since concurrency is not automatically enabled, if users are adding this setting to their host.json they should by default want it set to true. If they didn't want to enable dynamic concurrency this setting wouldn't be added to the host.json.

Here is a link to the vscode-azurefunctions issue for more info.

@GerryFerdinandus
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants