Push Framework argument for .net7.0

[nturinski]

@ejizba Just wanted to check with you on this-- so I should only have to pass --arg: Framework net7.0 on project creation since that is when the .csproj is generated and that's where Framework is actually replacing TargetFrameworkValue.

On a FunctionCreate, assumedly the project is already created with the appropriate .csproj file.

[alexweininger]

Is this not a CLI bug? I feel like it should do this for us.

[ejizba]

You might be able to just pass the projTemplateKey? I think it's designed to mimic the targetframework, although you might need to remove "isolated" maybe - checkout dotnetUtils for relevant code. In any case, this logic needs to be more generic to also support net48 and other frameworks moving forward

[ejizba]

@ejizba Just wanted to check with you on this-- so I should only have to pass --arg: Framework net7.0 on project creation since that is when the .csproj is generated and that's where Framework is actually replacing TargetFrameworkValue.

On a FunctionCreate, assumedly the project is already created with the appropriate .csproj file.

Yes that is correct

[ejizba]

cc @liliankasem

For Alex's context, this is a new change by Lilian to the .NET isolated templates. PR here: Azure/azure-functions-templates#1240. Basically, in the past the isolated worker only really supported one .NET version at a time (or at least only one we cared about for the sake of templates). Now, they support net48, net6.0, and net7.0 all at once which is why a new parameter was introduced. If the arg is not passed, it will currently default to net6.0.

Also - it's important to note that the version of the dotnet cli being used to create the project does not necessarily match the version of the project. I can have all three versions installed on my machine but I should still be able to pick which one I use for my project.

[nturinski]

For reference, our tests have been creating csproj files this way forever:

protected async initializeTestFolder(testFolder: string): Promise<void> {
        await super.initializeTestFolder(testFolder);
        await AzExtFsExtra.writeFile(path.join(testFolder, 'test.csproj'), `<Project Sdk="Microsoft.NET.Sdk">
    <PropertyGroup>
        <TargetFramework>${this._targetFramework}</TargetFramework>
    </PropertyGroup>
    <ItemGroup>
        <PackageReference Include="${this._isIsolated ? 'Microsoft.Azure.Functions.Worker.Sdk' : 'Microsoft.NET.Sdk.Functions'}" Version="1.0.0" />
    </ItemGroup>
</Project>`);
    }

So I think adding the target framework for all versions shouldn't break anything. Also tried with v3 and it doesn't seem to find the new argument.