Support java 17 runtime when create function project #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flanker32
force-pushed
the
java17-new-project
branch
from
417758c
to
c7b7bf9
Compare
shreyas-gopalakrishna
previously approved these changes
Sep 7, 2022
nturinski
reviewed
Sep 8, 2022
nturinski
reviewed
Sep 8, 2022
shreyas-gopalakrishna
previously approved these changes
Sep 12, 2022
nturinski
reviewed
Sep 12, 2022
| @@ -45,7 +45,7 @@ for (const version of [FuncVersion.v2, FuncVersion.v3, FuncVersion.v4]) { | |||
| const appName: string = 'javaApp'; | |||
| const javaBaseInputs: (TestInput | string | RegExp)[] = [TestInput.UseDefaultValue, TestInput.UseDefaultValue, TestInput.UseDefaultValue, TestInput.UseDefaultValue, appName]; | |||
| if (version !== FuncVersion.v2) { // v2 doesn't support picking a java version | |||
| javaBaseInputs.unshift(/11/); | |||
| javaBaseInputs.unshift(/8/); | |||
There was a problem hiding this comment.
Why did this get changed to an earlier version of Java?
There was a problem hiding this comment.
As some of the test environment uses java 8 as default java version, we add java version validation in this pr and will not provide java 11 as an option in this case
nturinski
approved these changes
Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new Java 17 runtime in function creation steps, fixes #3245