Allow users to specify open behavior for new project #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
approved these changes
May 8, 2018
| } | ||
|
|
||
| const uri: vscode.Uri = vscode.Uri.file(fsPath); | ||
| if (openBehavior === OpenBehavior.AddToWorkspace) { |
There was a problem hiding this comment.
I know it works, but why don't you have to specify OpenInCurrentWindow here?
There was a problem hiding this comment.
It's included in the 'else' case. The boolean I pass in with 'openBehavior === OpenBehavior.OpenInNewWindow /* forceNewWindow */ will evaluate to false and use the current window
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
After creating a new project, the user will be given three options to open that project:
This is what it looks like if they select "Always use this choice":
It's a user setting in the background, so people can always change it if they want. I also made sure to add telemetry to see if this kind of quick pick is worth doing in other places as well.