Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean script to TypeScript projects #3654

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add clean script to TypeScript projects #3654

merged 1 commit into from
Apr 24, 2023

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Apr 21, 2023

In model v4, the entrypoint is a glob (dist/src/functions/*.js) meaning if you delete a ts file in src, you also need to delete the js file in dist otherwise the function will still show up. This can be confusing, so probably worth adding a clean script.

A few notes:

  • rimraf v5 works in Node.js v14+, but I feel like that's fine since Node 12 was EOL April 2022
  • There's not as much value when adding this to the old model, but I thought it was easier to keep them consistent
  • I'm pretty sure my test changes work, but obviously I wasn't able to do a full test run given the state of the tests

@ejizba ejizba requested a review from a team as a code owner April 21, 2023 20:28
@nturinski
Copy link
Member

I'm pretty sure my test changes work, but obviously I wasn't able to do a full test run given the state of the tests

@ejizba ejizba merged commit 462add3 into main Apr 24, 2023
@ejizba ejizba deleted the ej/tsclean branch April 24, 2023 18:09
@microsoft microsoft locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants