Allow user to create an Event Hub namespace and/or Event Hub when creating EventHubTrigger #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating EventHubTrigger
bwateratmsft
previously approved these changes
Jun 14, 2023
src/commands/addBinding/settingSteps/eventHub/EventHubListStep.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
bwateratmsft
previously approved these changes
Jun 14, 2023
MicroFish91
reviewed
Jun 16, 2023
| @@ -11,6 +11,6 @@ export class EventHubNameStep extends StringPromptStep { | |||
| public shouldPrompt(context: IEventHubWizardContext & IBindingWizardContext): boolean { | |||
| // If the user decides to create a new app setting, `EventHubListStep` will take care of prompting | |||
| // Otherwise, prompt to manually enter the name of the event hub using this step | |||
| return !context.namespaceName && !context.eventhubname; | |||
| return !context.eventHubsNamespace && !context.eventhubname; | |||
There was a problem hiding this comment.
Nit: Camel case?
eventhubname => eventHubName
There was a problem hiding this comment.
There's a note in IEventHubWizardContext
/**
* NOTE: The name of this variable should not change. It matches the name of the binding setting written to function.json
*/
eventhubname?: string;
| newAuthRuleName?: string; | ||
| authRule?: AuthorizationRule; | ||
| newEventHubName?: string; | ||
| // Netherite uses all of the eventhub namespace settings in IEventHubWizardContext |
There was a problem hiding this comment.
I'll double check some Netherite scenarios to make sure this doesn't break. We'll probably want CTI to pay extra attention to this flow when they do their test pass
More motivation for me to get some tests in for Durable as well...
MicroFish91
reviewed
Jun 16, 2023
| import { ISubscriptionContext } from "@microsoft/vscode-azext-utils"; | ||
| import { EventHubsConnectionTypeValues, StorageConnectionTypeValues } from "../../../../constants"; | ||
| import { ISetConnectionSettingContext } from "../ISetConnectionSettingContext"; | ||
|
|
||
| export interface IEventHubsConnectionWizardContext extends ISetConnectionSettingContext, Partial<ISubscriptionContext> { | ||
| resourceGroup?: ResourceGroup; | ||
| resourceGroup?: ResourceManagementModels.ResourceGroup; |
There was a problem hiding this comment.
Should the types be more like this?
There was a problem hiding this comment.
Do you mean the spaces? I'm not sure what you're trying to highlight here.
Or the fact that it has resourceGroup as a property?
| @@ -24,7 +25,6 @@ import { CosmosDBListStep } from './cosmosDB/CosmosDBListStep'; | |||
| import { EventHubAuthRuleListStep } from './eventHub/EventHubAuthRuleListStep'; | |||
| import { EventHubConnectionCreateStep } from './eventHub/EventHubConnectionCreateStep'; | |||
| import { EventHubListStep } from './eventHub/EventHubListStep'; | |||
| import { EventHubNamespaceListStep } from './eventHub/EventHubNamespaceListStep'; | |||
There was a problem hiding this comment.
Are you missing an import for: EventHubsNamespaceListStep?
There was a problem hiding this comment.
No idea why that got removed...
…osoft/vscode-azurefunctions into nat/eventHubNamespaceCreate
…ions into nat/eventHubNamespaceCreate
alexweininger
previously approved these changes
Jun 26, 2023
src/commands/appSettings/connectionSettings/eventHubs/IEventHubsConnectionWizardContext.ts
Outdated
Show resolved
Hide resolved
alexweininger
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #3550