Hardcode default bundle version #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejizba
reviewed
Jun 23, 2023
| return feed.defaultVersionRange; | ||
| export async function getLatestVersionRange(_context: IActionContext): Promise<string> { | ||
| // const feed: IBundleFeed = await getBundleFeed(context, undefined); | ||
| // return feed.defaultVersionRange; |
There was a problem hiding this comment.
Looks like line 45 is also referencing feed.defaultVersionRange, which I'm guessing is why the tests are still failing
|
Do you know if the defaultVersionRange is [3.*, 4.0.0), would function v4 runtime be using the 3.x.x templates or the 4.x.x templates?? I tried the reverse (used v3 when the default range is 4.*) and it selected the 3.x.x templates. |
ejizba
approved these changes
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3711 and a bunch of yet to be discovered templates related issues.