Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix executing remote function #3788

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix executing remote function #3788

merged 1 commit into from
Aug 4, 2023

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Aug 4, 2023 •
edited
Loading

Fixes #3787

@alexweininger alexweininger requested a review from a team as a code owner August 4, 2023 20:19
nturinski
nturinski reviewed Aug 4, 2023
View reviewed changes
src/commands/executeFunction.ts
@@ -73,7 +73,7 @@ export async function executeFunction(context: IActionContext, node?: FunctionTr
'Content-Type': 'application/json',
});
if (client) {
headers['x-functions-key'] = (await client.listHostKeys()).masterKey;
headers.set('x-functions-key', (await client.listHostKeys()).masterKey ?? '');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same command that I was having issues with while testing log streaming btw. I have a feeling something is going on with that API and it's down again (regarding the customer issue)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to repro and verify that this fixed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What authority was your function though? If it was anonymous, you don't need a master key, but I think you would if it's function or admin.

@alexweininger alexweininger merged commit cf0c6a6 into main Aug 4, 2023
1 of 5 checks passed
@alexweininger alexweininger deleted the alex/pink-gayal branch August 4, 2023 21:15
@microsoft microsoft locked and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected status code: 401 when executing azure functions from vscode
2 participants
@alexweininger @nturinski