Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspace functions to extension API #3881

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

alexweininger
Copy link
Member

Goals:

  • Expose the workspace methods that Limelight needs in the extension API.
  • Provide typings for these APIs without exposing too much types from our own extension, that Limelight doesn't need

This got really messy so I ended up making some new types that are for the API, then some internal types that are only for our use. In the future if this becomes something that ends up being used a lot, we can clean it up. But it will require a lot of type refactoring and is not a small job.

@alexweininger alexweininger requested a review from a team as a code owner October 11, 2023 16:27
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexweininger alexweininger merged commit dfa434e into main Oct 11, 2023
4 of 5 checks passed
@alexweininger alexweininger deleted the alex/crimson-angelfish branch October 11, 2023 19:08
@microsoft microsoft locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants