Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventGrid Cloud Event templates for .NET to verified list #3916

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

hossam-nasr
Copy link
Contributor

As in title, add the new "EventGrid Cloud Event" templates to the verified list. The only tests failing now should be the TypeScript template count and the .NET isolated back up template count, which do not appear to be related to my changes.

Copy link
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests that are currently failing are unrelated to Hossam's changes. Latest version of TypeScript templates don't include the CosmosDB trigger for some reason. I've reached out to the partner team about it already.

@hossam-nasr hossam-nasr merged commit d080d3b into main Nov 29, 2023
1 of 5 checks passed
@hossam-nasr hossam-nasr deleted the hossamnasr/eventgrid-templates branch November 29, 2023 19:34
@microsoft microsoft locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants