-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Event Grid Local Development Experience #3984
Conversation
Yeah, we don't use prettier defaults in our extensions. I tended to use it as well in my own projects but had to turn off a lot of the default formatting to keep our work projects from getting auto formatted on save 😋
At first glance, the way you're using it looks okay to me. I wouldn't worry too much about the string id, the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For files that are edited due to your prettier, I think you can unstage those changes and just not push them up. I can't be sure, but it looks like there are some files that are only formatting changes, right?
As far as directory structure goes, I think there are enough EventGrid specific files that we should just create an executeFunction/eventGrid
folder.
src/commands/executeFunction/eventGrid/EventGridCodeLensProvider.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/EventGridEventSourceStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/EventGridEventTypeStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/OpenEventGridFileStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/OpenEventGridFileStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/OpenEventGridFileStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/OpenEventGridFileStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/OpenEventGridFileStep.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/ExecuteEventGridFunctionContext.ts
Outdated
Show resolved
Hide resolved
src/commands/executeFunction/eventGrid/EventGridEventSourceStep.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking great. Most of my comments are just nits or small questions. Nice work!
Improve the local development experience for EventGrid functions.
What this PR does:
When customer clicks on "Execute Function Now..." button, if it's an EventGrid function, the user is prompted to choose an event type from a list of supported file types:
The customer then selects one of sample event types under that event source, pulled from this repo:
If "send sample request" is selected, EventGrid function gets triggered with sample request.
If "modify sample request" is selected, a new window opens with the sample request:
Missing / Next steps:
.prettierrc
file configuration that would keeping the existing styling as-is. Any help there is appreciated.Open questions:
❓Do I need to do something extra to make localization work? I followed the pattern I saw of using the
localize
function, but I'm not sure how the code I used as the first argument gets used.❓Right now, I create the temp files that store these sample files in the
.vscode
directory. Would it be better if I saved it elsewhere, such as the OS temp file directory, by default?❓Because of the way the button and code lens need to be registered at the extension level, they appear in any
.eventgrid.json
file, even if no function is currently being executed or the function app is even running. Is there a way to stop them from showing unless the function app is running and a function is being executed?