Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlTrigger to verifiedtemplates #4095

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MaddyDev
Copy link

adding Sql trigger to verified templates

@MaddyDev MaddyDev requested a review from a team as a code owner April 22, 2024 18:11
@nturinski
Copy link
Member

Hi @MaddyDev

Part of our process to adding templates to the verified list is to create a test for creating that specific template trigger. We do this to ensure that the template is created as we expected and we can catch anytime the input/parameter change from what we expected.

Please add a test creating the sqlTrigger. Feel free to reach out and I can give you examples of how to do that.

@MaddyDev
Copy link
Author

MaddyDev commented Apr 25, 2024

Hi @MaddyDev

Part of our process to adding templates to the verified list is to create a test for creating that specific template trigger. We do this to ensure that the template is created as we expected and we can catch anytime the input/parameter change from what we expected.

Please add a test creating the sqlTrigger. Feel free to reach out and I can give you examples of how to do that.

Thanks @nturinski for calling out, I have added them and haven't pushed them. Quick question, I see that some of the extensions also edited templateCount.test.ts (ref https://github.com/microsoft/vscode-azurefunctions/pull/3916/files). Can you explain if this is needed for us?

@nturinski
Copy link
Member

@MaddyDev So it seems like a lot of the tests are failing now. Is the SqlTrigger actually available in all of these runtimes? Like Python, all .NET runtimes, etc.? It doesn't appear to be showing up.

@nturinski
Copy link
Member

@MaddyDev Just want to see if there's any update on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants