Add new command deployByFunctionAppId
#4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
approved these changes
May 14, 2024
|
Confirmed with partner team that needs this that it's working. We're having another issue with the defaultHostname thing, but that's unrelated to these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One or more teams currently leverage our deploy command directly using
commands.executeCommand. We previously allowed thefunctionAppIdtarget to be passed as a third argument intodeployProductionSlot. Upon investigation, I noticed that only the first arg was being passed down when wrapped withregisterCommandWithTreeNodeUnwrapping.Calling with
registerCommandinstead seems to preserve all args. As a workaround, I have created a command for these teams to utilize directly where the only thing you need to pass it is thefunctionAppId. This is probably better also because they are not really ever passing a tree item anyway, so we don't ever need to unwrap for their use-case.