Add an error when deploying a containerized function app instead of filtering out containerized function apps #4182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
previously approved these changes
Jun 13, 2024
|
Let Nathan look at this too |
nturinski
reviewed
Jun 14, 2024
| await context.ui.showWarningMessage(localize('containerFunctionAppError', 'Deploy is not supported for containerized function apps within the Azure Functions extension. Please use the Azure Container Apps extension to deploy your project.'), { learnMoreLink }); | ||
| //suppress display of error message | ||
| context.errorHandling.suppressDisplay = true; | ||
| throw new Error(); |
There was a problem hiding this comment.
We may want to make a new error for telemetry purposes. So we can track when the command is being used to deploy to a container app.
nturinski
approved these changes
Jun 14, 2024
nturinski
reviewed
Jun 14, 2024
| @@ -81,6 +81,15 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string | | |||
| return await getOrCreateFunctionApp(context) | |||
| }); | |||
|
|
|||
| if (node.contextValue.includes('container')) { | |||
| const learnMoreLink: string = 'https://aka.ms/deployContainerApps' | |||
| await context.ui.showWarningMessage(localize('containerFunctionAppError', 'Deploy is not supported for containerized function apps within the Azure Functions extension. Please use the Azure Container Apps extension to deploy your project.'), { learnMoreLink }); | |||
There was a problem hiding this comment.
Please use the Azure Container Apps extension to deploy your project
We should change this to something like. "Please read here to learn how to deploy your project" or something.
Maybe we should say Deploy is currently not supported as well since we plan to do it eventually.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is what the warning looks like:
It will point to a new github wiki page with instructions on how to deploy.
Todo:
Add a button to install ACA