Fix "+ Create new function app" error while deploying #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Jun 14, 2024
| const resolved = new ResolvedFunctionAppResource(context as ISubscriptionContext, nonNullProp(context, 'site')); | ||
| if (context.dockerfilePath) { | ||
| const resolved = new ResolvedContainerizedFunctionAppResource(context as ISubscriptionContext, nonNullProp(context, 'site')) | ||
| node = await ext.rgApi.tree.findTreeItem(resolved.id, context); |
There was a problem hiding this comment.
nit: You only need to set node once after the if/else.
You could also do a ternary for context.dockerfilePath ? new Resolve...
nturinski
approved these changes
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4175
Needed to add the
ResolvedContainerizedFunctionAppResourcebeing created when containerized function apps are being created through the deploy path. This is set up similarly to how it is done inSubscriptionTreeItem.