Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use getCompiledProjectInfo in pickProcess #4333

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

nturinski
Copy link
Member

I had originally thought it'd be smart to use it to get the buildPath easily, but it turns out that it throws an error if there is more than one csproj file. This, unsurprisingly, causes a lot of issues for users trying to debug.

Also fixed another issue where it said it could not find the process id. That is because runningFuncTask could also be an empty array, in which case, not undefined, but no process to kill.

@nturinski nturinski requested a review from a team as a code owner November 13, 2024 00:27
@nturinski nturinski merged commit 90439a6 into main Nov 13, 2024
2 checks passed
@nturinski nturinski deleted the nat/fix/4330 branch November 13, 2024 18:24
@microsoft microsoft locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants