Refactor pickProcess to leverage tasks api #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/commands/pickFuncProcess.ts
Outdated
| }); | ||
| }); | ||
| funcExecution.terminate(); | ||
| await waitForEndPromise; |
There was a problem hiding this comment.
Need to consider a timeout (e.g. vscode-cosmosdb\src\utils\timeout.ts)?
src/commands/pickFuncProcess.ts
Outdated
|
|
||
| return processList.map((proc: IProcess) => proc.pid); | ||
| let psTree: IProcessTreeNode = await new Promise((resolve: (psTree: IProcessTreeNode) => void): void => { | ||
| windowsProcessTree.getProcessTree(Number(pid), resolve); |
There was a problem hiding this comment.
What happens if the process ended before it got to here?
StephenWeatherford
approved these changes
Sep 4, 2018
ejizba
added a commit
that referenced
this pull request
Sep 7, 2018
As described in this PR: #558, we have to get the inner 'func' process on Windows instead of attaching to the parent PowerShell process. Well it turns out there's a delay between when the PowerShell process is created and when it has the child process running the func cli. This change prevents us from attaching to the PowerShell process and getting "unverified" breakpoints.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had a whole host of issues related to pickProcess for C# debugging. I was able to simplify this logic by leveraging VS Code's tasks api that was released a few months ago rather than searching the entire list of processes myself. The VS Code tasks api actually gives me the pid of the task, which is great.
Unfortunately it's never that simple, though 😅 On Windows, it gives me the pid of the parent PowerShell process, not the actual func process. In order to find the child process, I decided to leverage the windows-process-tree module that's created for and shipped with VS Code, which is a native windows module and avoids a lot of the problems we originally ran into with wmic (which most other modules like 'ps-node' use).
Fixes #436
Fixes #518
Fixes #534
Fixes #437