v2 edit tags command for resources #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweininger
force-pushed
the
alex/api-v2-edit-tags
branch
from
78eea8c to
080d53f
Compare
nturinski
reviewed
Dec 20, 2022
| @@ -46,7 +45,7 @@ export class AppResourceTreeItem extends ResolvableTreeItemBase implements Group | |||
| this.groupConfig = createGroupConfigFromResource(resource, root.id); | |||
|
|
|||
| this.contextValues.add(AppResourceTreeItem.contextValue); | |||
| ext.tagFS.fireSoon({ type: FileChangeType.Changed, item: this }); | |||
| // ext.tagFS.fireSoon({ type: FileChangeType.Changed, item: this }); | |||
There was a problem hiding this comment.
Could you explain why you commented this out? Should it go back eventually?
There was a problem hiding this comment.
This is a v1 class that isn't used anymore. It's a lot of work to delete everything, will do in a follow up PR.
There was a problem hiding this comment.
When I start deleting files it just shows how much there is left to do. For example:
- Toggle show all resources command
- Group by tags needs updated so that it doesn't rely on the root tree item to get subscriptions
revealTreeItem
I'm sure there's more
nturinski
approved these changes
Dec 21, 2022
This was referenced Dec 22, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on microsoft/vscode-azuretools#1257
I will add support for editing tags on resource groups in a follow up PR.
Also, I need to add a
dontUnwrapflag toappResourceExperiencein utils so to support getting an item from the picker here.