Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort workspace items by id #746

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Sort workspace items by id #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tree/workspace/WorkspaceResourceTreeDataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export class WorkspaceResourceTreeDataProvider extends ResourceTreeDataProviderB

// NOTE: Returning zero children indicates to VS Code that is should display a "welcome view".
// The one chosen for display depends on the context set above.
return children;
return children.sort((a, b) => a.id.localeCompare(b.id));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering-- should we separate the workspace items by which extension contributed them? Alphabetical order may not make that much sense,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that sorting by id would be most flexible. We can manage the ids as needed to sort it how we want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair enough.

}
}

Expand Down