Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic integration for Azure Web PubSub Service #777

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

xingsy97
Copy link
Member

Extension for Azure Web PubSub service is under developing.
Add basic integration for it.

@xingsy97 xingsy97 requested a review from a team as a code owner November 27, 2023 04:38
@xingsy97
Copy link
Member Author

@microsoft/vscodeazuretoolsdev

.github/workflows/build-and-release.yml Outdated Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@alexweininger
Copy link
Member

Do you have a link to the source code of the extension?

@xingsy97
Copy link
Member Author

xingsy97 commented Dec 5, 2023

@alexweininger All comments are resolved. I accidentally updated the branch for my personal test use several days ago.
We haven't publish the package code publicly, for the unsolved question I asked you whether the code could be put into our all-in-one repo https://github.com/azure/azure-webpubsub

@alexweininger
Copy link
Member

for the unsolved question I asked you whether the code could be put into our all-in-one repo https://github.com/azure/azure-webpubsub

It's fine if the code is located in an all-in-one repo. Our team probably prefers it to be stand alone, but it's fine either way. For example, the AZD extension is located in an all-in-one repo. https://github.com/Azure/azure-dev/tree/main/ext/vscode

@alexweininger alexweininger merged commit 152cbe3 into microsoft:main Apr 24, 2024
3 checks passed
@microsoft microsoft locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants