Throw an error for any item that resolves as undefined #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
previously approved these changes
Mar 1, 2024
bwateratmsft
reviewed
Mar 1, 2024
| @@ -571,7 +571,7 @@ | |||
| }, | |||
| "scripts": { | |||
| "vscode:prepublish": "npm run cleanReadme", | |||
| "build": "tsc && gulp webpack-prod", | |||
| "build": "tsc", | |||
There was a problem hiding this comment.
Is this intentionally included?
There was a problem hiding this comment.
Yeah, the npm run build shouldn't run webpack. It wasn't actually changing the line return await extension.activate(ctx, perfStats, true); either (where the true is ignoreBundle) so it wasn't actually prepping it to be used with webpack.
There was a problem hiding this comment.
Can confirm that this matches our other extensions
There was a problem hiding this comment.
We really should stop using Gulp and match the Docker extension's build scripts and such...
bwateratmsft
previously approved these changes
Mar 4, 2024
alexweininger
previously approved these changes
Mar 5, 2024
alexweininger
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates microsoft/vscode-azurefunctions#3851 and other issues, I'm sure
We see this error floating around quite often. While this doesn't actually fix it, at least the error makes a little more sense to the user.