Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bad semver check to fix CLI update notification #710

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Remove bad semver check to fix CLI update notification #710

merged 2 commits into from
Jun 20, 2022

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Jun 20, 2022 •
edited
Loading

  1. This check currently prevents the notification to update the CLI from appearing if the installed version and the newest version don't have the same major version number 🤦 .
  2. The logic was most likely copied from here in Functions, and shouldn't be needed for SWA. Func core tools follows a different versioning method, but the SWA CLI follows semver.
  3. Should increase the % of users on v1 of the CLI, which will allow us to remove/improve a lot of code.

@alexweininger alexweininger requested a review from a team as a code owner June 20, 2022 22:12
nturinski
nturinski approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@nturinski nturinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That'll be great for the release

@alexweininger
Copy link
Member Author

I'll merge after #708

@alexweininger alexweininger merged commit 1d22971 into main Jun 20, 2022
@alexweininger alexweininger deleted the alex/validateSwaIsLatest branch June 20, 2022 23:25
@alexweininger alexweininger mentioned this pull request Jun 20, 2022
Open
@microsoft microsoft locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nturinski nturinski nturinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @nturinski