Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating .NET 7.0 Functions #759

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Allow creating .NET 7.0 Functions #759

merged 2 commits into from
Nov 10, 2022

Conversation

alexweininger
Copy link
Member

@alexweininger alexweininger commented Nov 10, 2022

This will allow users to create .NET 7.0 Functions. However, if they have .NET 6.0 and .NET 7.0 installed locally, then we will still default to .NET 6.0.

Fixes #758

@alexweininger alexweininger requested a review from a team as a code owner November 10, 2022 01:10
bwateratmsft
bwateratmsft previously approved these changes Nov 10, 2022
Copy link
Contributor

@bwateratmsft bwateratmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending which you merge first, this will definitely yield a merge conflict with #760.

@nturinski
Copy link
Member

This will allow users to create .NET 7.0 Functions. However, if they have .NET 6.0 and .NET 7.0 installed locally, then we will still default to .NET 6.0.

Fixes #758

Does this mean the user never gets prompted for which .NET they want to use? And we'll only use .NET 7 if they have it installed?

If that's the case, I think we would want to change this behavior. I believe the Func CLI lets you create .NET 7 triggers with a .NET 6 runtime.

@alexweininger
Copy link
Member Author

alexweininger commented Nov 10, 2022

Does this mean the user never gets prompted for which .NET they want to use? And we'll only use .NET 7 if they have it installed?

Yes.

If that's the case, I think we would want to change this behavior. I believe the Func CLI lets you create .NET 7 triggers with a .NET 6 runtime.

I agree, but wanted to at least enable it for now. Letting users pick will be a larger change (and need to happen in Functions). I will create a new issue for that.

#761

@alexweininger alexweininger merged commit 9e56d88 into main Nov 10, 2022
@alexweininger alexweininger deleted the alex/dotnet7-funcs branch November 10, 2022 18:52
@microsoft microsoft locked and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Node.js 18 and .NET 7
3 participants