-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to tree item picker #1232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brandon Waterloo [MSFT] <36966225+bwateratmsft@users.noreply.github.com>
* Make unwrap not a Promise * Move types into index.d.ts from hostapi.v2.d.ts
Falls back to show all children if no children are direct/indirect picks
bwateratmsft
reviewed
Sep 7, 2022
utils/src/treev2/quickPickWizard/experiences/appResourceExperience.ts
Outdated
Show resolved
Hide resolved
utils/src/treev2/quickPickWizard/quickPickAzureResource/QuickPickAppResourceStep.ts
Outdated
Show resolved
Hide resolved
bwateratmsft
approved these changes
Sep 7, 2022
RGs branch compatible with these changes is https://github.com/microsoft/vscode-azureresourcegroups/tree/alex/v2-pick-tree-item2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Brandon Waterloo [MSFT] 36966225+bwateratmsft@users.noreply.github.com
Changes in this PR are the ones required to get the tree item picker to work. I will follow up with another PR to add the experience builder.