Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Add additional child nesting and error item support to the activity log #1636

Merged
merged 8 commits into from
Dec 6, 2023

Conversation

MicroFish91
Copy link
Contributor

@MicroFish91 MicroFish91 commented Nov 27, 2023

Will eventually be incorporated to support this update: microsoft/vscode-azurecontainerapps#576

I wanted to figure out a convention for handling how errors get displayed in the activity log. I currently have it working like this:

  1. If error suppression flag is set, don't attach any error items
  2. Otherwise, if the last activity child is a fail item, try to add the caught error as a child of the existing fail item:

image

  1. Otherwise, if last item is not a fail item, just tack the error on at the end:

image

Let me know if something like this makes sense.

@MicroFish91 MicroFish91 marked this pull request as ready for review November 27, 2023 23:53
@MicroFish91 MicroFish91 requested a review from a team as a code owner November 27, 2023 23:53
@MicroFish91 MicroFish91 force-pushed the mwf/activity-log-nesting branch from 7b6222d to 5421b0d Compare November 30, 2023 22:10
@MicroFish91 MicroFish91 force-pushed the mwf/activity-log-nesting branch from 5421b0d to 1a93436 Compare November 30, 2023 22:15
nturinski
nturinski previously approved these changes Nov 30, 2023
Base automatically changed from mwf/generic-parent-item to main November 30, 2023 23:29
@MicroFish91 MicroFish91 dismissed nturinski’s stale review November 30, 2023 23:29

The base branch was changed.

@MicroFish91 MicroFish91 merged commit f97c793 into main Dec 6, 2023
4 checks passed
@MicroFish91 MicroFish91 deleted the mwf/activity-log-nesting branch December 6, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants