-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: Ensure JWT redaction for error messages #1768
Conversation
This reverts commit 5852321.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that they were fake tokens, but I did double-check to verify that they were. I am concerned that cred-scan is going to flag us for having PAT in our code now even if it is for testing purposes.
Yeah fake credentials, but valid JWTs. I think it will be okay because of this inclusion in the {
"file": "utils\\test\\masking.test.ts",
"_justification": "Fake credentials used for unit tests."
} |
Ensure anything resembling a JWT is automatically redacted from errors before submitting to telemetry