Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add account parameter to isSignedIn #1819

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Add account parameter to isSignedIn #1819

merged 2 commits into from
Nov 19, 2024

Conversation

alexweininger
Copy link
Member

Fixes #1809

@alexweininger alexweininger requested a review from a team as a code owner November 18, 2024 23:57
motm32
motm32 reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@motm32 motm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also add the account parameter to the AzureSubscriptionProvider interface?

@alexweininger alexweininger merged commit 0ecfad7 into main Nov 19, 2024
4 checks passed
@alexweininger alexweininger deleted the alex/1809-fix branch November 19, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motm32 motm32 motm32 approved these changes

@StephenWeatherford StephenWeatherford Awaiting requested review from StephenWeatherford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSubscriptions() throws if user has signed in to two accounts
2 participants
@alexweininger @motm32