Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: Add check in getTenants #1822

Merged
merged 1 commit into from
Nov 19, 2024
Merged

auth: Add check in getTenants #1822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions auth/src/VSCodeAzureSubscriptionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,14 @@ export class VSCodeAzureSubscriptionProvider extends vscode.Disposable implement
const results: TenantIdDescription[] = [];

for await (account of account ? [account] : await vscode.authentication.getAccounts(getConfiguredAuthProviderId())) {
const { client } = await this.getSubscriptionClient(account, undefined, undefined);
// Added check. Without this the getSubscriptionClient function throws the NotSignedInError
if (await this.isSignedIn(undefined, account)) {

for await (const tenant of client.tenants.list()) {
results.push(tenant);
const { client } = await this.getSubscriptionClient(account, undefined, undefined);

for await (const tenant of client.tenants.list()) {
results.push(tenant);
}
}
}

Expand Down
Loading