Implement activity log to create and delete virtual machines #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
reviewed
Aug 14, 2024
| const iconPath = options.activityStatus === 'Success' ? activitySuccessIcon : options.activityStatus === 'Fail' ? activityFailIcon : activityProgressIcon; | ||
|
|
||
| return { | ||
| item: new GenericTreeItem(undefined, { |
There was a problem hiding this comment.
Small nit, but for fail items, I would pass back a GenericParentTreeItem by default since we have logic that will automatically tack on error items as children if thrown in that step 🤓
MicroFish91
reviewed
Aug 14, 2024
|
|
||
| import { activityFailContext, activityFailIcon, activityProgressContext, activityProgressIcon, activitySuccessContext, activitySuccessIcon, AzureWizardExecuteStep, createUniversallyUniqueContextValue, GenericTreeItem, type ExecuteActivityOutput, type IActionContext } from "@microsoft/vscode-azext-utils"; | ||
|
|
||
| export abstract class AzureWizardActivityOutputExecuteStep<T extends IActionContext> extends AzureWizardExecuteStep<T> { |
There was a problem hiding this comment.
I like it. For most cases it will simplify quickly hooking up new steps. For more custom cases, we can implement the execute step manually or overwrite the existing methods here.
There was a problem hiding this comment.
Yeah, my thoughts exactly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on microsoft/vscode-azuretools#1767
This is just an idea of how we could implement this across other extensions. We could move the step I made or leave it to the extension to figure out how they want to implement all of this activity log shenanigans.
Let me know if you have any thoughts on other ways we could make it easier to implement, whether it's shared in the npm package or if there's something I did weird/stupid in this PR.
An example of what it looks like in action:
