This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Small fixes #326
Merged
Small fixes #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually maybe I hit merge too quickly, why wasn't the error handled upstream? It should have failed the request or something? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.remoteObjectToVariable at line 2141 was throwing an exception in some cases for the Edge debug adapter. The .catch change is so it'll catch that kind of issues too. The change to remoteObjectToVariable is for the same reason: this.createPrimitiveVariable was throwing an exception in Edge debug adapter, and no-one was catching it.
The removeAllListeners change is because while using the debugServer we create one new chrome connection each time you launch, so we ended up having several listeners for these events