Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select a Kit dropdown appears for non-CMake projects after installation or when activation by an extension takes too long #1007

Closed
sean-mcmanus opened this issue Jan 16, 2020 · 4 comments
Labels
Milestone

Comments

@sean-mcmanus
Copy link
Contributor

Bug#1: Install CMake Tools with a non-CMake project and the Select a Kit dropdown appears.
Bug#2: Put a breakpoint in the activation() method of another extension (e.g. the C/C++ extension) or otherwse cause "too slow" activation, which causes VS Code's "workspace contains **/CMakeLists.txt" activation to switch to "*" activation, causing "Select a Kit" to appear for non-CMake projects.

The fix for both of these would be to be to check on activation if the real activation conditions really occurred or not, similar to what the C/C++ extension does. Other fixes might be possible too.

Bug#3: When the above bugs are hit, then the select a kits also appears after adding a new workspace folder for a non-CMake folder.

@sean-mcmanus sean-mcmanus added the bug a bug in the product label Jan 16, 2020
@Zingam
Copy link
Contributor

Zingam commented Jan 23, 2020

Can we also get rid of CMake extension related UI widgets/elements like these:
image
If there is no "CMakeLists.txt" in the folder?

@sean-mcmanus
Copy link
Contributor Author

This occurs very frequently in cold start scenarios, such as when a TypeScript/non-CMake folder is opened for the first time. Also seems to occur more often when extensions are updated.

@andreeis
Copy link
Contributor

andreeis commented Mar 1, 2021

Fixed by PR #1689.

@andreeis
Copy link
Contributor

CMake Tools 1.7.0 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants