Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure kit selection quickPick doesn't show on non CMake projects #1689

Merged
merged 8 commits into from
Mar 2, 2021

Conversation

andreeis
Copy link
Contributor

@andreeis andreeis commented Mar 1, 2021

Fix for #1578.
Plus the following:

  • rename for commands related to edit cache UI, they were confusingly named openConfiguration
  • edit cache was not guarded by full feature set, being available in the UI for non CMake projects
  • resetState command is useful even if the current project is seen as non CMake (mostly to identify bugs when the extension analyzes wrong this aspect). It's inconvenient to have resetState not available (it's hard to get out of a bad state when investigating some bugs)
  • the extension would show full features (until the next reload) even if the single project in the workspace would be disabled, because we were calculating the state of the workspace too early

src/cmake-tools.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@andreeis andreeis merged commit 98cccc2 into develop Mar 2, 2021
@andreeis andreeis deleted the dev/andris/cmake_tools/SkipKitsScanOnNonCMakeProj branch March 2, 2021 19:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants